Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] appimage-run: parse readelf's output in C locale #104798

Merged
merged 1 commit into from Nov 24, 2020
Merged

[20.09] appimage-run: parse readelf's output in C locale #104798

merged 1 commit into from Nov 24, 2020

Conversation

symphorien
Copy link
Member

fixes #101137

(cherry picked from commit 4d51f95)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien symphorien changed the title appimage-run: parse readelf's output in C locale [20.09] appimage-run: parse readelf's output in C locale Nov 24, 2020
@symphorien symphorien merged commit 0912cf9 into NixOS:release-20.09 Nov 24, 2020
@symphorien symphorien mentioned this pull request Nov 24, 2020
Merged
10 tasks
@symphorien symphorien deleted the appimage-run-locale-20.09 branch November 24, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@symphorien