Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustscan: 1.10.1 -> 2.0.1 #104786

Merged
merged 1 commit into from Nov 24, 2020
Merged

rustscan: 1.10.1 -> 2.0.1 #104786

merged 1 commit into from Nov 24, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 24, 2020

Motivation for this change

Bump rustscan to 2.0.1 (version reports as 2.0.0, Cargo.toml still says 2.0.0 RustScan/RustScan#320)
./result/bin/rustscan -a 127.0.0.1 works

Since this is a breaking version change (1 to 2) change is there any documentation that needs updating?

Ignored new tests that required perl and python. Could add them but they don't look too valuable...
https://github.com/RustScan/RustScan/blob/21b92a1d1b8f9a5895705617881551e26bbbf0cf/src/scripts/mod.rs#L454-L473

https://github.com/RustScan/RustScan/blob/master/fixtures/.rustscan_scripts/test_script.py

import sys

print('Python script ran with arguments', str(sys.argv))

https://github.com/RustScan/RustScan/blob/master/fixtures/.rustscan_scripts/test_script.pl

my $total = $#ARGV + 1;
my $counter = 1;
 
# get script name
my $scriptname = $0;
 
print "Total args passed to $scriptname : $total\n";
 
# Use loop to print all args stored in an array called @ARGV
foreach my $a(@ARGV) {
	print "Arg # $counter : $a\n";
	$counter++;
}

Maintainer ping: @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104786 1

1 package built:
  • rustscan

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104786 run on x86_64-darwin 1

1 package built:
  • rustscan

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104786 run on x86_64-linux 1

1 package built:
  • rustscan

@SuperSandro2000
Copy link
Member

I tried getting the tests to work but I couldn't in a reasonable amount of time. I think it is fine to disable them. Waiting for ofborg now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants