Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svtplay-dl: 2.7 -> 2.8 #104777

Merged
merged 3 commits into from Nov 24, 2020
Merged

svtplay-dl: 2.7 -> 2.8 #104777

merged 3 commits into from Nov 24, 2020

Conversation

mandrean
Copy link
Contributor

  • svtplay-dl: 2.7 -> 2.8
  • svtplay-dl: Enable on macOS as well
Motivation for this change

This PR updates svtplay-dl to the latest release, and enables it on macOS as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mandrean
Copy link
Contributor Author

Question to maintainer @rycee:

Shouldn't ffmpeg_3 be set as a runtime dep...since, it is, on all platforms?

@ofborg ofborg bot requested a review from rycee November 24, 2020 17:53
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104777 run on x86_64-darwin 1

1 package built:
  • svtplay-dl

@rycee
Copy link
Member

rycee commented Nov 24, 2020

@mandrean Hmm, yeah. It makes sense to add a ffmpeg dependency. My use of svtplay-dl has never needed it, though. I can see about adding it.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104777 run on x86_64-linux 1

1 package built:
  • svtplay-dl

@rycee rycee self-assigned this Nov 24, 2020
@rycee rycee force-pushed the update/svtplay-dl branch 3 times, most recently from b2ed0f3 to 57deabd Compare November 24, 2020 19:05
@rycee rycee merged commit 9a515a9 into NixOS:master Nov 24, 2020
@rycee
Copy link
Member

rycee commented Nov 24, 2020

Merged to master now. Thanks for the contribution @mandrean and the review @SuperSandro2000!

@mandrean mandrean deleted the update/svtplay-dl branch November 24, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@rycee rycee Awaiting requested review from rycee

Assignees

@rycee rycee

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mandrean @SuperSandro2000 @rycee @Janik-Haag