Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] qt5{14,15}.qtbase: fix on darwin #104194

Merged
merged 1 commit into from Nov 18, 2020
Merged

[20.09] qt5{14,15}.qtbase: fix on darwin #104194

merged 1 commit into from Nov 18, 2020
+196 −242

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 18, 2020 •
edited

(cherry picked from commit 0c74da1)

Motivation for this change

Backport #103528

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
qt5{14,15}.qtbase: fix on darwin
58f9c4c 
(cherry picked from commit 0c74da1)
@veprbl veprbl requested a review from ttuegel as a code owner November 18, 2020 17:53
@veprbl veprbl merged commit 58f9c4c into NixOS:release-20.09 Nov 18, 2020
@veprbl veprbl deleted the pr/qt515_darwin_fix_20.09 branch November 18, 2020 18:45
@veprbl veprbl restored the pr/qt515_darwin_fix_20.09 branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl