Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.117.6 -> 0.118.0 #104202

Merged
merged 3 commits into from Nov 19, 2020
Merged

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://www.home-assistant.io/blog/2020/11/18/release-118/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@mvnetbiz mvnetbiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt
Copy link
Member Author

Yep, correct. I tracked that issue and then … forgot. Thanks for the reminder.

@ofborg ofborg bot requested a review from mvnetbiz November 19, 2020 05:43
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
test passes

Result of nixpkgs-review pr 104202 1

4 packages built:
  • home-assistant
  • python37Packages.hass-nabucasa
  • python38Packages.hass-nabucasa
  • python38Packages.zigpy-zigate

Copy link
Contributor

@mvnetbiz mvnetbiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@jonringer jonringer merged commit 9e8e0c7 into NixOS:master Nov 19, 2020
@mweinelt mweinelt deleted the home-assistant branch November 19, 2020 12:45
@@ -20,7 +20,7 @@ buildPythonPackage rec {
src = fetchFromGitHub {
owner = "zigpy";
repo = "zigpy-zigate";
rev = version;
rev = "v${version}";
sha256 = "EV6DV+BytUcPMtzYVKDnq/Uv2efg3stjL5uVlL62II4=";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash update missing, fixed in #104280.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's my bad, must have been looking at an old "files changed"

Copy link
Member Author

@mweinelt mweinelt Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure It was my fault. Anyway, happens. No harm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants