New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home-assistant: 0.117.6 -> 0.118.0 #104202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed now.
https://github.com/NixOS/nixpkgs/blob/ce4069119e7ec3aa4fad12ded33c7fac74a9f54c/pkgs/servers/home-assistant/default.nix#L27-L30
I am waiting on #104227 to test my complete setup.
ce40691
to
4db4338
Compare
Yep, correct. I tracked that issue and then … forgot. Thanks for the reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test passes
Result of nixpkgs-review pr 104202
1
4 packages built:
- home-assistant
- python37Packages.hass-nabucasa
- python38Packages.hass-nabucasa
- python38Packages.zigpy-zigate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good
@@ -20,7 +20,7 @@ buildPythonPackage rec { | |||
src = fetchFromGitHub { | |||
owner = "zigpy"; | |||
repo = "zigpy-zigate"; | |||
rev = version; | |||
rev = "v${version}"; | |||
sha256 = "EV6DV+BytUcPMtzYVKDnq/Uv2efg3stjL5uVlL62II4="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash update missing, fixed in #104280.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's my bad, must have been looking at an old "files changed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure It was my fault. Anyway, happens. No harm done.
Motivation for this change
https://www.home-assistant.io/blog/2020/11/18/release-118/
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)