Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] fix lutris, attempt wine fix #104198

Closed
wants to merge 6 commits into from
Closed

[staging-next] fix lutris, attempt wine fix #104198

wants to merge 6 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 18, 2020 •
edited

Motivation for this change

trying to fix some packages before they land in master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title Fix wine staging next [staging-next] fix lutris, attempt wine fix Nov 18, 2020
@jonringer
Copy link
Contributor Author

I was able to launch StarCraft2 through lutris

@jonringer
Copy link
Contributor Author

jonringer commented Nov 20, 2020 •
edited

Seems I'm just unable to build it, but hydra can build it fine

@jonringer jonringer closed this Nov 20, 2020
@jonringer jonringer deleted the fix-wine-staging-next branch November 20, 2020 18:23
@jonringer
Copy link
Contributor Author

I may split some of this into different PRs

@SFrijters
Copy link
Member

To avoid possible duplicate work, note that #103233 is also being worked on.

@jonringer
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SFrijters