Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_testing_bcachefs: 5.8.0-2020.09.07 -> 5.9.0-2020.11.17 // bcachefs-tools: 2020-08-25 -> 2020-11-17 #104197

Merged
merged 2 commits into from Dec 22, 2020
Merged

linux_testing_bcachefs: 5.8.0-2020.09.07 -> 5.9.0-2020.11.17 // bcachefs-tools: 2020-08-25 -> 2020-11-17 #104197

merged 2 commits into from Dec 22, 2020

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

Update bcachefs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Chiiruno Chiiruno requested a review from eadwu November 18, 2020 18:45
@ofborg ofborg bot requested a review from davidak November 18, 2020 19:28
@Chiiruno
Copy link
Contributor Author

cc @davidak

davidak
davidak approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

not tested

@davidak
Copy link
Member

davidak commented Dec 22, 2020

I successfully build the kernel, booted into it, formatted a filesystem and mounted it.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/301

@AndersonTorres AndersonTorres merged commit 6690232 into NixOS:master Dec 22, 2020
@davidak davidak mentioned this pull request Dec 22, 2020
Closed
SuperSandro2000
SuperSandro2000 reviewed Dec 23, 2020
View reviewed changes
pkgs/tools/filesystems/bcachefs-tools/default.nix
nativeBuildInputs = [
pkgconfig
];
nativeBuildInputs = [ pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be pkg-config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treewide substitution time!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

@Chiiruno Chiiruno deleted the dev/bcachefs branch December 25, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@davidak davidak davidak approved these changes

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Chiiruno @davidak @nixos-discourse @AndersonTorres @SuperSandro2000 @Madouura