Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svt-av1: init at 0.8.6 // ffmpeg-full: enable svt-av1 #104195

Merged
merged 2 commits into from Jan 7, 2021
Merged

svt-av1: init at 0.8.6 // ffmpeg-full: enable svt-av1 #104195

merged 2 commits into from Jan 7, 2021

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

Encode with svt-av1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from codyopel November 18, 2020 18:47
SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to wait until the next release before adding this. They might find more bugs and fix them.

pkgs/development/libraries/ffmpeg-full/default.nix Outdated Show resolved Hide resolved
@Chiiruno
Copy link
Contributor Author

cc @codyopel

@Chiiruno Chiiruno changed the title svt-av1: init at 0.8.5 // ffmpeg-full: enable svt-av1 svt-av1: init at 0.8.6 // ffmpeg-full: enable svt-av1 Dec 4, 2020
@ofborg ofborg bot requested a review from codyopel December 4, 2020 14:21
@marsam marsam force-pushed the dev/svt-av1 branch 4 times, most recently from 2b856ab to c378a33 Compare January 7, 2021 00:01
@marsam
Copy link
Contributor

marsam commented Jan 7, 2021

@GrahamcOfBorg build svt-av1
@GrahamcOfBorg build ffmpeg-full

@marsam marsam merged commit 3e635c6 into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chiiruno @marsam @codyopel @SuperSandro2000 @Madouura