Skip to content

nixos/telegraf: fix test #104206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2020
Merged

nixos/telegraf: fix test #104206

merged 3 commits into from
Nov 18, 2020
+9 −13

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 18, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Mic92 added 3 commits November 18, 2020 21:41
@Mic92
nixos/telegraf: null value for environmentFiles is invalid

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
GPG key ID: 003F2096411B5F92
Verified
Learn about vigilant mode
69caedc 
it's also not needed given that empty list covers all use cases.
@Mic92
nixos/telegraf: make example a bit more compact

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
GPG key ID: 003F2096411B5F92
Verified
Learn about vigilant mode
0f84e08
@Mic92
nixos/telegraf: fix test

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
GPG key ID: 003F2096411B5F92
Verified
Learn about vigilant mode
58bf9ed
@Mic92 Mic92 changed the title Telegraf nixos/telegraf: fix test Nov 18, 2020
@Mic92
Copy link
Member Author

Mic92 commented Nov 18, 2020

@GrahamcOfBorg test telegraf

@Mic92 Mic92 merged commit 624285d into NixOS:master Nov 18, 2020
@Mic92 Mic92 deleted the telegraf branch November 18, 2020 20:55
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92