Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.haskell-language-server: Enable tests #104215

Merged
merged 1 commit into from Nov 19, 2020
Merged

haskellPackages.haskell-language-server: Enable tests #104215

merged 1 commit into from Nov 19, 2020

Conversation

maralorn
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cdepillabout
cdepillabout reviewed Nov 19, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-nix.nix Outdated
Comment on lines 830 to 831
mkdir home
export HOME=$(pwd)/home
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nixpkgs you often see export HOME=$TMPDIR (but there does seem to be a lot of variation in this).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's a function call less, so I'll go with that.

@maralorn
Copy link
Member Author

Sadly I'll leave the tests disabled because some of them are flaky. But I'll merge the fixes anyway, because I want to keep them.

@maralorn maralorn merged commit 8f885d1 into NixOS:haskell-updates Nov 19, 2020
@maralorn maralorn deleted the disable-hls-tests branch November 19, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout