Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.WWWTwilioAPI: init at 0.21 #104240

Merged
merged 1 commit into from Nov 20, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 19, 2020

Motivation for this change

Adds the WWW::Twilio::API perl module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

2 packages built:
  • perl530Packages.WWWTwilioAPI
  • perl532Packages.WWWTwilioAPI

Cc: @zakame @SuperSandro2000

@zakame
Copy link
Member

zakame commented Nov 19, 2020

The examples.pl got installed in the lib (alongside the module,) probably needs removing (or moving it elsewhere prior to the perl Makefile.PL call so it doesn't get picked up:)

θ60° [zakame:~/.cache … -review/pr-104240] % tree results/perl530Packages.WWWTwilioAPI/
results/perl530Packages.WWWTwilioAPI/
├── lib
│   └── perl5
│       ├── 5.30.3
│       │   └── x86_64-linux-thread-multi
│       │       └── perllocal.pod
│       └── site_perl
│           └── 5.30.3
│               ├── WWW
│               │   └── Twilio
│               │       ├── API.pm
│               │       └── examples.pl
│               └── x86_64-linux-thread-multi
│                   └── auto
│                       └── WWW
│                           └── Twilio
│                               └── API
└── nix-support
    └── propagated-build-inputs

14 directories, 4 files

(I think this is also an upstream issue, we could probably report it too...)

@zakame
Copy link
Member

zakame commented Nov 19, 2020

I've reported the issue above to upstream https://rt.cpan.org/Ticket/Display.html?id=133774 💪

@stigtsp stigtsp force-pushed the package/perl-www-twilio-api-init branch from b000224 to 1cbdc21 Compare November 20, 2020 17:20
@zakame
Copy link
Member

zakame commented Nov 20, 2020

Result of nixpkgs-review pr 104240 1 on other Linux:

2 packages built:
  • perl530Packages.WWWTwilioAPI
  • perl532Packages.WWWTwilioAPI

@stigtsp
Copy link
Member Author

stigtsp commented Nov 20, 2020

@zakame Thx for the testing :)

@stigtsp
Copy link
Member Author

stigtsp commented Nov 20, 2020

@GrahamcOfBorg build perlPackages.WWWTwilioAPI perldevelPackages.WWWTwilioAPI

@stigtsp stigtsp merged commit 96d9861 into NixOS:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants