prometheus: 2.22.1 -> 2.22.2 #104213
prometheus: 2.22.1 -> 2.22.2 #104213
Conversation
| @@ -59,7 +59,7 @@ in buildGoPackage rec { | |||
| cp -a $src/console_libraries $src/consoles $out/etc/prometheus | |||
| ''; | |||
|
|
|||
| doCheck = true; | |||
| doCheck = !stdenv.isDarwin; # https://hydra.nixos.org/build/130673870/nixlog/1 | |||
There was a problem hiding this comment.
Seems likely since upstream is also not testing on macOS: https://app.circleci.com/pipelines/github/prometheus/prometheus/9912/workflows/47d71aaf-7e51-4dc6-9ea7-0f8611f75e61/jobs/43784
|
Tests are failing on x86_64-linux: https://hydra.nixos.org/build/130839618 |
|
Builds locally, can you reproduce the failure? |
|
Yes. One of my machines ran into this problem when building from master and Hydra produces the error as well. Interestingly OfBorg reported a successful build on the last commit in this PR's source branch. Maybe the problem only occured after merging it with the latest master changes. Reverting the "prometheus: 2.22.1 -> 2.22.2" commit definitely fixes the build. |
|
It's now building on hydra. https://hydra.nixos.org/build/131079975 |
|
I was able to build both revisions on another machine, so it might just be some non-deterministic tests or the hosts running out of resources. |
WilliButz
added
the
8.has: port to stable
Motivation for this change
This stopped building after #102986, seems to be the only one affected.
Darwin tests have been broken since the
2.22version bump.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)