Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rippled: unbreak adding libnsl #104220

Merged
merged 1 commit into from Nov 23, 2020
Merged

rippled: unbreak adding libnsl #104220

merged 1 commit into from Nov 23, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

From hydra error I saw the problem with libnsl missing in buildInputs.

I tried to compile it, but didn't succeed my machine was frozen around 81%, so thank you to check it on your side before merging

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from offlinehacker and ehmry November 18, 2020 23:44
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 19, 2020 •
edited

I get the following on non NixOS.

CMake Error at /nix/store/3n8l407vj5fw9q3yx6w0b0hhyg2f19ry-cmake-3.18.4/share/cmake-3.18/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/nix/store/n3r351j7vfr2bv95fp6miz3l8741jdb4-gcc-wrapper-9.3.0/bin/gcc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /build/rippled/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/nix/store/kzdxdj5lis8d9lwjhmgzdxqbnhjhg277-gnumake-4.3/bin/make cmTC_65029/fast && /nix/store/kzdxdj5lis8d9lwjhmgzdxqbnhjhg277-gnumake-4.3/bin/make  -f CMakeFiles/cmTC_65029.dir/build.make CMakeFiles/cmTC_65029.dir/build
    make[1]: Entering directory '/build/rippled/build/CMakeFiles/CMakeTmp'
    make[1]: /bin/sh: No such file or directory
    make[1]: *** [CMakeFiles/cmTC_65029.dir/build.make:84: CMakeFiles/cmTC_65029.dir/testCCompiler.c.o] Error 127
    make[1]: Leaving directory '/build/rippled/build/CMakeFiles/CMakeTmp'
    make: *** [Makefile:140: cmTC_65029/fast] Error 2





  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:7 (project)

@freezeboy
Copy link
Contributor Author

What a weird error...

@SuperSandro2000
Copy link
Member 

    make[1]: /bin/sh: No such file or directory

Sandbox issue. hydra probably can build it.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104220 1

1 package failed to build: rippled-validator-keys-tool
1 package built: rippled

@RaghavSood
Copy link
Member

That is expected though, rippled-validator-keys-tool hasn't been updated in a long time - I would update it in another PR

@RaghavSood RaghavSood merged commit ddb17aa into NixOS:master Nov 23, 2020
@freezeboy freezeboy deleted the unbreak-rippled branch November 23, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

@RaghavSood RaghavSood RaghavSood approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @SuperSandro2000 @RaghavSood @offlinehacker