Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tubeup: unbreak #104222

Merged
merged 2 commits into from Nov 28, 2020
Merged

python3Packages.tubeup: unbreak #104222

merged 2 commits into from Nov 28, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 18, 2020 •
edited

Motivation for this change

Unbreak tubeup python module. It seems there are two different youtube-dl(c) packages.
The selected one was not the correct one

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy changed the title Unbreak tubeup python3Packages.tubeup: unbreak Nov 18, 2020
@ofborg ofborg bot requested a review from marsam November 18, 2020 23:56
jonringer
jonringer reviewed Nov 19, 2020
View reviewed changes
pkgs/development/python-modules/youtube-dlc/default.nix Outdated
sha256 = "WqoKpfvVPZrN+pW6s8JoApJusn5CXyPcg9VcsY8R0FM=";
};

outputs = [ "out" "dev" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
outputs = [ "out" "dev" ];

common for python packages to use this to pass runtime packages

cat ./result-dev/nix-support/propagated-build-inputs
/nix/store/18656kvqazm74bj7k3mdkwmdlqfyf581-python3-3.8.6  /nix/store/wwsf5czpcmxbqzqv5p623cc40jdn6cg0-python3.8-youtube_dlc-2020.11.11.post3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's solved.

@freezeboy
python3Packages.youtube-dlc: init at 2020.11.11.post3
6bc5957
@freezeboy
python3Packages.tubeup: unbreak wrong youtube dep
442bd5b 
There are two packages used to download from youtube:
youtube-dl and youtube-dlc, this packaged was using the
wrong one
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104222 run on x86_64-linux 1

5 packages built:
  • python27Packages.youtube-dlc
  • python37Packages.tubeup
  • python37Packages.youtube-dlc
  • python38Packages.tubeup
  • python38Packages.youtube-dlc

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 104222 run on x86_64-linux 1

Thanks @SuperSandro2000 .

@doronbehar doronbehar merged commit a42535b into NixOS:master Nov 28, 2020
@freezeboy freezeboy deleted the unbreak-tubeup branch November 28, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@doronbehar doronbehar doronbehar approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @SuperSandro2000 @doronbehar @jonringer