Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause panning in intro game while user is interacting with the GUI #9645

Merged
merged 1 commit into from Oct 23, 2021

Conversation

frosch123
Copy link
Member

@frosch123 frosch123 commented Oct 22, 2021

Motivation / Problem

When interacting with the GUI and settings windows, the moving background of the intro game is disturbing.

Description

The intro game animation checks the mouse position for activity.

  • Panning/vehicle-following is only happening while the mouse is idle.
  • When the mouse does not move for 2 seconds, panning is reactivated.
  • The animation continues normally, even while panning is suppressed:
    • Non-panning actions are executed normally.
    • When the mouse becomes idle, the animation catches-up to panning-actions/vehicle-following in progress.

Limitations

This PR is in "draft" state, because I included the 12.0 titlegame for the "preview" build.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@frosch123 frosch123 added the preview This PR is receiving preview builds label Oct 22, 2021
@DorpsGek DorpsGek temporarily deployed to preview-pr-9645 October 22, 2021 16:45 Inactive
src/intro_gui.cpp Outdated Show resolved Hide resolved
@DorpsGek DorpsGek temporarily deployed to preview-pr-9645 October 22, 2021 17:33 Inactive
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Oct 22, 2021
@TrueBrain
Copy link
Member

Looks good! Bit choppy when the animation continues again, but little we can do about it :D Let's ship it!

@DorpsGek DorpsGek temporarily deployed to preview-pr-9645 October 23, 2021 12:34 Inactive
@frosch123 frosch123 removed the preview This PR is receiving preview builds label Oct 23, 2021
@frosch123 frosch123 marked this pull request as ready for review October 23, 2021 12:35
@frosch123 frosch123 merged commit e8bff0a into OpenTTD:master Oct 23, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 23, 2021
@LC-Zorg
Copy link

LC-Zorg commented Oct 23, 2021

Last preview shows that you want to replace the current opntitle with the default one used in the JGR version. This is the intention? :) If not and it is supposed to work like in the previous preview, this change doesn't fix anything and it gets even worse. Much worse.

The constant changes of the background, especially in such an erratic way, only irritate and distract when the player needs to change something in the settings or worse read and understand. The necessity of constantly moving the mouse to prevent this from happening is even more irritating, especially since it doesn't help much.

I would suggest editing the current save and removing the panning signs, as well as extending the spacing between view changes.
Another, in my opinion, interesting option is the solution proposed by Kamnet, i.e. creating an intro that would use the same save with the game logo visible, and after clicking, show the menu and stop the view changes: in the current location or in the first one.

@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants