Feature: Ctrl-click to remove fully autoreplaced vehicles from list #9639
Conversation
2TallTyler
force-pushed
the
autoreplace_ctrl_click
branch
from
c3b878d
to
dfc234d
Compare
I didn't know this feature before. :) I tried to find arguments against, but I don't see them for this moment. Now that there's already a similar use of Ctrl + click, it seems quite sensible and useful. |
|
I had to go a LONG way back (2005), but it used to be that when there were no more vehicles left to replace, they would automatically be removed from the list. The last version where you can see this behaviour is 0.4.0.1. The release notes for 0.4.5 mention a complete rewrite of the autoreplace code so perhaps there was a technical reason for the change. If not for a technical reason, I can't think what purpose the current behaviour serves. No further actions can be performed once all the selected vehicles have been replaced, and I can't see why a player would need to be reminded of the what the old vehicle was. I'm probably overlooking something obvious. |
|
We discussed this on Discord, and at least one user mentioned that having the replaced vehicles hang around acted as a confirmation that the replacement was complete. I disagree and would prefer them to disappear automatically, but Ctrl-clicking is a good compromise. 😄 |
|
Ah, that's fair enough. Maybe a news message would serve that purpose better though. In any case, it's not a big issue and, like you said, ctrl+clicking is a good compromise. |
Motivation / Problem
When autoreplacing vehicles with another type, the old vehicle type is greyed out when none remain. Removing these empty vehicles from the list is fairly annoying, especially if you have a lot of vehicles to remove — when I play, I forget to autoreplace on a regular basis and tend to upgrade a lot of vehicle types at once.
Description
When buying vehicles, we can Ctrl-click on a vehicle to hide it from the menu in a single action.
Now we can do that with autoreplace, but only for vehicles for which none remain.
This works identically to the Stop Replacing Vehicles button, so it respects groups.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.