New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Duplicate entries in multiplayer server list #74
Comments
This ticket lacks a bit of information for me to do anything with. Sure, there are a few "duplicated entries", but those are in fact different servers which happen to have the same name. Can you provide screenshots of the issue you are seeing. Please create a screenshot of both servers you consider duplicates, including the part on the right that shows the details of that server. With that info I can trace what you are actually seeing and what is going on :) Tnx! |
They also run two different versions. This suggests to me that someone is actually running both. I will investigate, but this feels like "human error" :) |
The server name
When clicking "Refresh" on both servers, the 1985 entry goes "SERVER OFFLINE", while the 2030 entry remains online and updates accordingly, but returns to the previous date on the next "Search Internet". Possible solutionPossible solution: Enforce uniqueness in the name of the server. In other words: * Starting a server with name "Unnamed Server" will hide it from server listings. * Starting two servers with the same name will hide one of them from server listings. * Instead of hiding from server listings, a number would be appended to the server name in the listings, such as `My Server (2)`. |
Before we jump to conclusions, lets first gather facts ;) So basically, for pre-12.0 servers that have more than one IP, you see 1 entry each. This has always been the case, so that on its own is not a bug/problem. 12.0 solves that (finally). The only thing I wonder about is why one is updated (server-info-wise) and the other is not. That is something I want to look into :) |
It's more likely bug of game controller than OpenTTD itself, since OpenTTD only displays what is sent in the GC listing packet. I am quite sure that experienced community servers like BTpro and Arctic tycooners does not run servers with the same names. And displaying two entries for each IP type or invite code is at best confusing. Little sidenote: I also find it pretty useless to send some 6000+ newgrf info in the GC listing packet, since there is usually around 700-800 unique NewGRFs online at any time. But then, it could make only maybe 300kB difference in packet size, so maybe it's not so big deal nowadays. |
This comment has been minimized.
This comment has been minimized.
Observed behaviour:
Did a rolling restart of the GC instances; resolved all issues. Which means the database was correct, just the reflection of it in the GC instances was not. Moving ticket to GC repo. |
Restarting it was unfortunately only temporary solution. There are already new duplicates. |
Version of OpenTTD
from 12.0 onward
Expected result
Unique servers in server list
Actual result
Duplicate entries in server list, when search internet is pressed in lobby window
Steps to reproduce
Click search internet in multiplayer window.
Look for duplicate entries, there's aplenty.
The text was updated successfully, but these errors were encountered: