-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert mathematica, physics, astronomy and testing_utilities to DiscreteTraject0ry #3170
Conversation
Lt(1 * Deci(Metre) / Second)) | ||
<< "orbit of satellite " << satellite << " flowing from point " | ||
<< i; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes to this block and the preceding one; the binding adds verbosity and indentation and doesn’t gain much (the frame conversion probably ought to operate directly on the value_type
anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reverting entirely because the indent was wrong in the original code.
Instant const& t, | ||
ODEAdaptiveStepParameters<ODE> const& parameters, | ||
std::int64_t max_ephemeris_steps) { | ||
Instant const& trajectory_last_time = trajectory->back().time; | ||
auto const& [trajectory_last_time, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good binding.
I have used a few structured bindings in places where they seemed to improve the code.
#3136.