Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mathematica, physics, astronomy and testing_utilities to DiscreteTraject0ry #3170

Merged
merged 7 commits into from
Oct 24, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 24, 2021

I have used a few structured bindings in places where they seemed to improve the code.

#3136.

Lt(1 * Deci(Metre) / Second))
<< "orbit of satellite " << satellite << " flowing from point "
<< i;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to this block and the preceding one; the binding adds verbosity and indentation and doesn’t gain much (the frame conversion probably ought to operate directly on the value_type anyway).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reverting entirely because the indent was wrong in the original code.

@eggrobin eggrobin added the LGTM label Oct 24, 2021
@pleroy pleroy merged commit 4b094a9 into mockingbirdnest:Ondelette Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants