Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for empty segments #3172

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 27, 2021

  1. ForgetBefore doesn't delete segments, but leaves empty segments as needed to avoid changing the structure of the trajectory and invalidating iterators.
  2. Iterators now know how to skip over empty segments.

#3136.

@@ -88,8 +88,12 @@ class DiscreteTraject0ry : public Trajectory<Frame> {
SegmentIterator AttachSegments(DiscreteTraject0ry&& trajectory);
void DeleteSegments(SegmentIterator begin);

// Deletes the point at times in [t, end[. Drops empty segment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

points? segments?

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Oct 27, 2021
@pleroy pleroy merged commit 551ea14 into mockingbirdnest:delaValléePoussin Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants