Fix #8797: Use logical rail length when placing signals #9652
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
|
This is what it currently does with minimize_gaps and gap 2. Also there is an emscripten preview so you can try whatever you want yourself right in the browser. |
|
Generally it's not bad, but with the current positioning of the signaling it looks ugly. Without aligning signals, it won't be a good change for many players. Currently (at the top), the distances between signals are 18 and 42 pixels. In addition, one of the signals is a pixel lower than the other. At the bottom, it is equal to 30 and 30. Likewise for vertical tracks. I don't see why these signals should remain so unevenly placed. Btw. I would see another method here that would help keep traffic flowing without the need of ugly signals compaction. There could be even less of this signals... In short: "Start braking when you see the red light" |
|
Signal sprite offsets are a separate issue. Signal placer doesn't even build signals that close in a "pretty" mode anyway. |
|
Separate, but not entirely so, because this change would significantly emphasize these inequalities. For spacing settings of 3 or more, it looks fine. Setting 1 and 2 is problematic. Another significant problem is the continuation of the game with the changed building rules. So maybe instead of an on/off switch, three points to choose would be better? |
|
If the alignment is fixed, people will complain because trains don't stop in front of signals. |
|
If people were to complain about it, they should be doing it now. :D Currently After change In front of the station |
|
The real reason for the "misalignment" is so that signals do not overlap when train lines run next to each other
Now, that's enough off-topic discussion, please keep further discussion to the actual PR subject. |
This comment was marked as abuse.
This comment was marked as abuse.
Motivation / Problem
As described in #8797 signal placer uses some visual distance instead of logical distance to place signals requiring players who need a certain logical gap to place additional signals manually.
Description
Interprets signal distance in the UI as the logical length of that many X/Y tiles of rail. And uses the logical length of the track pieces (i.e. 192 or 128 units) when calculating the distance between signals placed.
When "keep fixed distance" setting is off (i.e. minimize_gaps = true) ensures that gap between signals never exceeds the required signal distance except for when it's on a bridge or tunnel.
Without minimize_gaps (i.e. "pretty" mode) just tries to place signals as soon as accumulated gap >= required distance regardless of whether it succeeds or not.
Also, this placer is mostly ready to work with segments of arbitrary logical length if that ever makes into the game.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.