Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing commas in crash message for savegame crash due to missing NewGRF #9648

Closed
James103 opened this issue Oct 23, 2021 · 0 comments

Comments

@James103
Copy link
Contributor

Version of OpenTTD

e8bff0a

Expected result

  • Current: "same GRF ID OpenTTD cannot magically do the right thing. In most\n"
    Correct line: "same GRF ID, OpenTTD cannot magically do the right thing. In most\n" (comma after "same GRF ID")
  • Current: "cases OpenTTD will load the savegame and not crash, but this is an\n"
    Correct line: "cases, OpenTTD will load the savegame and not crash, but this is an\n" (comma after "In most cases")

Corrected message:

 p += seprintf(p, lastof(buffer), 
 	"This is most likely caused by a missing NewGRF or a NewGRF that\n" 
 	"has been loaded as replacement for a missing NewGRF. OpenTTD\n" 
 	"cannot easily determine whether a replacement NewGRF is of a newer\n" 
 	"or older version.\n" 
 	"It will load a NewGRF with the same GRF ID as the missing NewGRF.\n" 
 	"This means that if the author makes incompatible NewGRFs with the\n" 
 	"same GRF ID, OpenTTD cannot magically do the right thing. In most\n" 
 	"cases, OpenTTD will load the savegame and not crash, but this is an\n" 
 	"exception.\n" 
 	"Please load the savegame with the appropriate NewGRFs installed.\n" 
 	"The missing/compatible NewGRFs are:\n"); 

Actual result

p += seprintf(p, lastof(buffer),
"This is most likely caused by a missing NewGRF or a NewGRF that\n"
"has been loaded as replacement for a missing NewGRF. OpenTTD\n"
"cannot easily determine whether a replacement NewGRF is of a newer\n"
"or older version.\n"
"It will load a NewGRF with the same GRF ID as the missing NewGRF.\n"
"This means that if the author makes incompatible NewGRFs with the\n"
"same GRF ID OpenTTD cannot magically do the right thing. In most\n"
"cases OpenTTD will load the savegame and not crash, but this is an\n"
"exception.\n"
"Please load the savegame with the appropriate NewGRFs installed.\n"
"The missing/compatible NewGRFs are:\n");

Steps to reproduce

  1. Load a saved game where you do not have the exact required NewGRFs, such that it crashes during load.
  2. Notice the typos in the resulting crash message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant