Fix #49: include EINTS manual in the Docker image #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
reviewed
Sep 29, 2021
| RUN make -C /docs && \ | ||
| mv /docs/manual/_build/html /code/static/docs && \ | ||
| rm -r /docs | ||
|
|
There was a problem hiding this comment.
Ideally, we do a multi stage Dockerfile so we don't get make in the final image.
Check website's Dockerfile if you wonder how that works.
TrueBrain
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to documentation points to openttdcoop.org (and it's currently down).
As the documentation is generated from eints repo, I think it's a good idea to include it in the image and stop relying on an external location.