Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.12.4 -> 1.13.0, riot-{web,desktop}: 1.6.0 -> 1.6.1 #88171

Merged
merged 3 commits into from May 20, 2020
Merged

matrix-synapse: 1.12.4 -> 1.13.0, riot-{web,desktop}: 1.6.0 -> 1.6.1 #88171

merged 3 commits into from May 20, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 19, 2020

Motivation for this change

Some Matrix-related updates:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label May 19, 2020
Ma27 added 2 commits May 19, 2020 16:32
@Ma27
riot-desktop: 1.6.0 -> 1.6.1
307dfd9 
https://github.com/vector-im/riot-desktop/releases/tag/v1.6.1

Also updated the package since `riot-desktop` has been moved to its own
repository (`github.com/vector-im/riot-desktop`).
@Ma27
matrix-synapse: 1.12.4 -> 1.13.0
2a5b0bc 
https://github.com/matrix-org/synapse/releases/tag/v1.13.0
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 88171 1

2 packages built:
- matrix-synapse
- riot-desktop

mweinelt
mweinelt approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly tested riot-desktop and seemed fine.

@blitz
Copy link
Contributor

blitz commented May 19, 2020

I gave riot-desktop a spin and didn't notice any issues.

@srhb srhb merged commit 0fc9fc0 into NixOS:master May 20, 2020
@Ma27 Ma27 deleted the matrix-updates branch May 20, 2020 10:06
@Ma27 Ma27 mentioned this pull request May 20, 2020
Merged
10 tasks
@Ma27
Copy link
Member Author

Ma27 commented May 20, 2020

Ported the riot-* updates to stable: 5d12be8, 0436b0d

Also opened a backport PR for matrix-synapse since this the release has some non-trivial changes and I'd prefer to get a review on this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blitz blitz blitz approved these changes

@mweinelt mweinelt mweinelt approved these changes

@Ekleog Ekleog Ekleog approved these changes

@fadenb fadenb fadenb approved these changes

@Ralith Ralith Awaiting requested review from Ralith

@pacien pacien Awaiting requested review from pacien

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @mweinelt @blitz @Ekleog @fadenb @srhb