Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: 5.0.403652.0509 -> 5.0.408598.0517 #88170

Merged
merged 1 commit into from May 21, 2020
Merged

zoom-us: 5.0.403652.0509 -> 5.0.408598.0517 #88170

merged 1 commit into from May 21, 2020

Conversation

glittershark
Copy link
Member

Motivation for this change

zoom has been segfaulting for me pretty frequently at the version in
master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from danbst and tadfisher May 19, 2020 14:23
@flokli
Copy link
Contributor

flokli commented May 19, 2020

Is this the latest version now?

@glittershark
Copy link
Member Author

yep

@doronbehar
Copy link
Contributor

Works for me, thanks. This derivation gets updated frequently but it's update doesn't land in Nixpkgs as fast. It has a passthru.updateScript but IIRC it's being run by humans right? Maybe we could setup something to update it faster?

@flokli
Copy link
Contributor

flokli commented May 21, 2020

I assume it's not run by r-ryantm or other automated tooling, as it's unfree software.

@flokli flokli merged commit 9dfcff3 into NixOS:master May 21, 2020
@glittershark glittershark deleted the update-zoom branch May 21, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst Awaiting requested review from danbst

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glittershark @flokli @doronbehar