New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmark broken package: dhall-lsp-server #88426
Merged
cdepillabout
merged 1 commit into
NixOS:haskell-updates
from
gvolpe:unmark-broken-package/dhall-lsp-server
May 23, 2020
Merged
Unmark broken package: dhall-lsp-server #88426
cdepillabout
merged 1 commit into
NixOS:haskell-updates
from
gvolpe:unmark-broken-package/dhall-lsp-server
May 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd appreciate if someone would explain the error in the checks:
|
gvolpe
force-pushed
the
unmark-broken-package/dhall-lsp-server
branch
from
May 20, 2020 13:37
60e0ddb
to
455cb27
Compare
Thanks for sending this PR! Once you remove the change in |
gvolpe
force-pushed
the
unmark-broken-package/dhall-lsp-server
branch
from
May 22, 2020 07:34
455cb27
to
f8624e6
Compare
Done @cdepillabout , thanks for your help! |
Thanks for updating this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The package is marked as broken on
master
.Things done
I removed the package from the list of broken packages and added an override to not check the failing test suite. I guess it's a fairly trivial change but this is the first time I do it, so please let me know if something is wrong.
I verified it works by running the following command:
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)