Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1639256 - Coerce all wpt paths to unicode, r=maja_zf #23696

Closed
wants to merge 1 commit into from

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented May 19, 2020

No description provided.

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

self.name = name # type: Union[bytes, Text]
self.ext = ext # type: Union[bytes, Text]
self.type_flag = type_flag # type: Optional[Union[bytes, Text]]
self.tests_root = ensure_text(tests_root) # type: Text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit / purely aesthetic: I might prefer treating this the same way as rel_path (i.e. have tests_root_str and tests_root).

@jgraham jgraham closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants