Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhine, rhine-gloss: Remove broken marker #88180

Merged
merged 1 commit into from May 20, 2020
Merged

rhine, rhine-gloss: Remove broken marker #88180

merged 1 commit into from May 20, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented May 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I cloned fresh from master and tested like this:

$ echo "{ allowBroken = true; }" > ~/.config/nixpkgs/config.nix

$ nix repl .
Welcome to Nix version 2.3.4. Type :? for help.

Loading '.'...
Added 11883 variables.

nix-repl> :b haskellPackages.rhine
[2 built, 43 copied (132.5 MiB), 10.6 MiB DL]

this derivation produced the following outputs:
  doc -> /nix/store/2x5g9gk7396nz20fcglrca0cxrav5w97-rhine-0.6.0-doc
  out -> /nix/store/nq99lc10zm9wg0g50pmbhjzmikan66bn-rhine-0.6.0

nix-repl> :b haskellPackages.rhine-gloss
[2 built, 47 copied (1010.7 MiB), 142.0 MiB DL]

this derivation produced the following outputs:
  doc -> /nix/store/062pizv6mczkqb25fbcwgdf8a13h3flv-rhine-gloss-0.6.0.1-doc
  out -> /nix/store/aw6lcfcx06apx2jxq30ibs9vcgpaqqa1-rhine-gloss-0.6.0.1
``

@turion turion requested a review from cdepillabout as a code owner May 19, 2020 17:43
@turion
Copy link
Contributor Author

turion commented May 19, 2020

I have no idea what the error message is trying to tell me.

@cdepillabout
Copy link
Member

Looks good, both of these build. Thanks!

@cdepillabout cdepillabout merged commit ef42212 into NixOS:haskell-updates May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turion @cdepillabout