Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 81.0.4044.138 -> 83.0.4103.61 #88206

Merged
merged 1 commit into from May 20, 2020
Merged

chromium: 81.0.4044.138 -> 83.0.4103.61 #88206

merged 1 commit into from May 20, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented May 19, 2020 •
edited

https://chromereleases.googleblog.com/2020/05/stable-channel-update-for-desktop_19.html

This update includes 38 security fixes.

CVEs:
CVE-2020-6465 CVE-2020-6466 CVE-2020-6467 CVE-2020-6468 CVE-2020-6469
CVE-2020-6470 CVE-2020-6471 CVE-2020-6472 CVE-2020-6473 CVE-2020-6474
CVE-2020-6475 CVE-2020-6476 CVE-2020-6477 CVE-2020-6478 CVE-2020-6479
CVE-2020-6480 CVE-2020-6481 CVE-2020-6482 CVE-2020-6483 CVE-2020-6484
CVE-2020-6485 CVE-2020-6486 CVE-2020-6487 CVE-2020-6488 CVE-2020-6489
CVE-2020-6490 CVE-2020-6491

BTW (in case that causes confusion): Upstream skipped Chromium 82, see https://chromereleases.googleblog.com/2020/03/chrome-and-chrome-os-release-updates.html.

Testing status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium ✔️ @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bendlas and thefloweringash May 19, 2020 22:22
@danielfullmer
Copy link
Contributor

Built and tested nixosTests.chromium and chromium on x86_64-linux.

thefloweringash
thefloweringash approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@thefloweringash thefloweringash left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested building, some browsing, youtube, and nix-build nixos/tests/chromium.nix -A stable on aarch64-linux.

@mostafahussein
Copy link

mostafahussein commented May 20, 2020 •
edited

It takes a lot of time in these steps:

ninja: Entering directory `out/Release'
[1406/1406] LINK ./mksnapshot_without_compiler.stampdtp.stamp.stamporm_v8.oKKable.o
ninja: Entering directory `out/Release'
[3/3] LINK ./chrome_sandboxome_sandbox/sandbox.o_linux.o
ninja: Entering directory `out/Release'

it took 2 hours until now and I am still waiting
Also, the process itself needs a lot of disk space until now it took more than 4GB which is not normal for installing an application. Is there a better way to follow in order to install the latest version of chromium?

I am using the latest version of the OS itself with the latest kernel

@primeos
Copy link
Member Author

primeos commented May 20, 2020

Is there a better way to follow in order to install the latest version of chromium?

Unfortunately not really, Chromium is just that big (one of the largest open-source projects).
I also want to use this chance to link The reckless, infinite scope of web browsers.

To receive Chromium updates I'd recommend to use a channel and wait for Hydra to finish building it (or get an AMD Ryzen Threadripper :D).

@primeos primeos merged commit 674c4f1 into NixOS:master May 20, 2020
@primeos primeos mentioned this pull request May 20, 2020
Merged
10 tasks
@primeos primeos mentioned this pull request May 20, 2020
Merged
10 tasks
primeos added a commit to primeos/nixpkgs that referenced this pull request May 20, 2020
@primeos
chromium: Mark as insecure
69e4ae5 
Since M81 won't receive any updates anymore and there are known
vulnerabilities we should mark it as insecure so that users are aware of
the risks.
Updating Chromium to M83 is unfortunately too challenging for
19.09, but as of today we've already covered the one month period of
security updates for "oldstable" and both 20.03 and nixos-unstable
contain recent versions (i.e. users should either update to the current
stable release or install Chromium from a different channel).

nixos-unstable PR for M83: NixOS#88206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash thefloweringash approved these changes

@danielfullmer danielfullmer danielfullmer approved these changes

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @danielfullmer @mostafahussein @thefloweringash