Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme-client: 0.2.5 -> 1.0.1 #88201

Merged
merged 3 commits into from Jun 16, 2020
Merged

acme-client: 0.2.5 -> 1.0.1 #88201

merged 3 commits into from Jun 16, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented May 19, 2020 •
edited

Motivation for this change

A new version has been released upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Initially this pull request was for version 1.0.0, which needed a small patch for a missing include. This has now been fixed upstream in version 1.0.1, and I have updated this pull request accordingly.

@ruuda
acme-client: 0.2.5 -> 1.0.0
d4c80a4 
The upstream version fails to compile due to a missing limits.h include.
I added a patch to fix that.

I opened a pull request to upstream it too, but the project has moved
from GitHub onto sr.ht and now asks me to send a patch to the mailing
list. My default email client is not really suitable for that, and
getting git-send-email set up will take some work, so in the meantime
it is easier to just patch it here.
@ofborg ofborg bot requested a review from pmahoney May 19, 2020 21:20
@graywolf
Copy link

1.0.1 is out and includes your patch. I would also suggest using tar balls from https://data.wolfsden.cz/sources/, it will allow you to skip the autoreconf step in your build process.

@ruuda
acme-client: 1.0.0 -> 1.0.1
d4d36c3 
I submitted my patch upstream, it was merged, and version 1.0.1 which
includes it has been released. So the patch here is no longer necessary.

Also, the maintainer added a Nixpkgs-based build environment to the
upstream CI setup, so in the future the upstream version will likely
not need any patching.
@ruuda ruuda changed the title acme-client: 0.2.5 -> 1.0.0 acme-client: 0.2.5 -> 1.0.1 May 24, 2020
@ruuda
acme-client: use source tarball to avoid autoreconf
bdd706c 
This was suggested by the upstream maintainer [1], and it is a nice
simplification. Also change the url to sr.ht as the project has moved
there.

[1]: NixOS#88201 (comment)
@ruuda
Copy link
Contributor Author

ruuda commented May 24, 2020

1.0.1 is out and includes your patch.

Thanks for the quick release! I updated this pull request.

I would also suggest using tar balls from https://data.wolfsden.cz/sources/, it will allow you to skip the autoreconf step in your build process.

I did not know about these sources, thanks for the suggestion. That is a nice simplification of the package, I added that to this PR.

@pmahoney, could you please take a look?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/180

pmahoney
pmahoney approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@pmahoney pmahoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@graywolf is that URL preferable to, e.g. https://git.sr.ht/~graywolf/acme-client-portable/archive/v1.0.1.tar.gz ? Is it documented somewhere other than your comment above?

@graywolf
Copy link

In general yes, it is preferable, since it is output of make dist with all
the implications. It is not documented anywhere, which is a good point. I
should probably put the link somewhere.

@Lassulus Lassulus merged commit c56895b into NixOS:master Jun 16, 2020
@ruuda ruuda deleted the acme-client-1.0 branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmahoney pmahoney pmahoney approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ruuda @graywolf @nixos-discourse @pmahoney @Lassulus