Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trilium: 0.42.2 -> 0.42.7 #88263

Merged
merged 4 commits into from Jul 9, 2020
Merged

trilium: 0.42.2 -> 0.42.7 #88263

merged 4 commits into from Jul 9, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented May 20, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented May 20, 2020

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@ofborg ofborg bot requested a review from dtzWill May 20, 2020 09:03
@kampka kampka changed the title trilium: 0.42.2 -> 0.42.3 trilium: 0.42.2 -> 0.42.5 Jun 3, 2020
@kampka
Copy link
Contributor Author

kampka commented Jun 3, 2020

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@kampka kampka changed the title trilium: 0.42.2 -> 0.42.5 trilium: 0.42.2 -> 0.42.6 Jun 3, 2020
@kampka kampka changed the title trilium: 0.42.2 -> 0.42.6 trilium: 0.42.2 -> 0.42.7 Jun 8, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/187

@kampka
Copy link
Contributor Author

kampka commented Jun 23, 2020

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@dtzWill dtzWill merged commit 9518824 into NixOS:master Jul 9, 2020
@dtzWill
Copy link
Member

dtzWill commented Jul 9, 2020

(-> 0.43.1, thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @nixos-discourse @dtzWill