Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the planned initial Frenet frame before ignition #2584

Merged
merged 2 commits into from
May 20, 2020

Conversation

eggrobin
Copy link
Member

On ignition, switch to tracking the current actual Frenet frame (current behaviour).

Fix #2577; all Principia burns can now be executed by MechJeb, and MechJeb warps properly.

@pleroy pleroy added the LGTM label May 20, 2020
: plugin->renderer().FrenetToWorld(
*plugin->GetVessel(vessel_guid),
*manœuvre.frame(),
plugin->PlanetariumRotation()))(manœuvre.direction());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the two branches would be more similar (and the code more transparent) if we had a FrenetToBarycentric instead of a FrenetToWorld because the barycentric-to-world conversion could be factored out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

This would also be far more readable if Manœuvre::FrenetFrame were called Manœuvre::InitialFrenetFrame.

Let’s do these cleanups in a subsequent pull request.

@eggrobin eggrobin merged commit 17b8ecd into mockingbirdnest:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The manœuvre node marker should show the ignition orientation prior to ignition for guided burns
2 participants