Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbguard: 0.7.6 -> 0.7.8 + systemd service update #88193

Merged
merged 3 commits into from May 24, 2020
Merged

usbguard: 0.7.6 -> 0.7.8 + systemd service update #88193

merged 3 commits into from May 24, 2020

Conversation

tnias
Copy link
Contributor

@tnias tnias commented May 19, 2020 •
edited

Motivation for this change

Update to latest USBGuard release and use upstream systemd service sandboxing.

https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.7
https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.8

Things done

I tested basic functionality. Such as allowing devices and writing persistent rules via usbguard append-rule ....

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tnias tnias changed the title usbguard 0.7.6 -> 0.7.7 + systemd service update usbguard: 0.7.6 -> 0.7.7 + systemd service update May 19, 2020
@tnias tnias changed the title usbguard: 0.7.6 -> 0.7.7 + systemd service update usbguard: 0.7.6 -> 0.7.8 + systemd service update May 20, 2020
bjornfor
bjornfor approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: typo in a commit message: sanboxing -> sandboxing.

tnias added 2 commits May 24, 2020 10:12
@tnias
nixos/usbguard: update systemd sandboxing features
98d1d4a 
Apply upstream systemd service configuration options to improve
sandboxing.
@tnias
usbguard: 0.7.7 -> 0.7.8
42675a3
@tnias
Copy link
Contributor Author

tnias commented May 24, 2020

typo fixed

@bjornfor bjornfor merged commit 20ebb13 into NixOS:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnias @bjornfor