Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-notes: document buildGoModule changes better. #88258

Merged
merged 1 commit into from May 21, 2020
Merged

release-notes: document buildGoModule changes better. #88258

merged 1 commit into from May 21, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 20, 2020

Motivation for this change

#86376 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request May 20, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented May 20, 2020

Thanks, that's a very useful explanation.

@Mic92 Mic92 merged commit 062d950 into master May 21, 2020
@Mic92 Mic92 deleted the go-module branch May 21, 2020 16:40
@Br1ght0ne Br1ght0ne mentioned this pull request May 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @nh2 @Ma27