Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: use buildPythonPackage #88367

Merged
merged 1 commit into from May 20, 2020
Merged

pre-commit: use buildPythonPackage #88367

merged 1 commit into from May 20, 2020

Conversation

eonpatapon
Copy link
Contributor

@eonpatapon eonpatapon commented May 20, 2020 •
edited

Motivation for this change

Allows to build a python env with pre_commit module:

python3.withPackages(p: [p.pre-commit])

pre-commit is already converted to an application in git-and-tools/default.nix:

pre-commit = pkgs.python3Packages.toPythonApplication pkgs.python3Packages.pre-commit;

So that it can still be installed as a standalone application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eonpatapon
pre-commit: use buildPythonPackage
15da907 
Allows to build a python env with pre_commit module:

  python3.withPackages(p: [p.pre-commit])

pre-commit is already converted to an application in `git-and-tools/default.nix`:

  pre-commit = pkgs.python3Packages.toPythonApplication pkgs.python3Packages.pre-commit;

So that it can still be installed as a standalone application.
@FRidh FRidh merged commit ec46eaa into NixOS:master May 20, 2020
@ofborg ofborg bot requested a review from borisbabic May 20, 2020 10:38
@eonpatapon eonpatapon deleted the pre-commit-module branch July 19, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@borisbabic borisbabic Awaiting requested review from borisbabic

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eonpatapon @FRidh