Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: build chromiumOzone #85197

Closed
wants to merge 1 commit into from
Closed

chromium: build chromiumOzone #85197

wants to merge 1 commit into from

Conversation

offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented Apr 14, 2020 •
edited

Motivation for this change

I need chromium build for wayland and do not want to rebuild every time myself, as it takes a long time to build. Here is people having their own forks, and having their own CI for that, so i see others have similar needs: https://github.com/colemickens/nixpkgs-chromium. This makes me think having hydra build chromium with ozone support is beneficial for others.

Currently to have it start you need to have gallium iris driver: https://nixos.wiki/wiki/Intel_Graphics and start with chromium --ozone-platform=wayland

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member

primeos commented Apr 14, 2020

Related discussion: #82443

This will unfortunately have to wait for a bit until we've resolved #85253 but we can discuss it in the meantime.

I also thought about this and I'd prefer to call it chromium-experimental. Why?:

  • It's not officially supported (both upstream and by us as we only have capacity to test one build and maintaining Chromium is already demanding enough - i.e. while we'll try to avoid it the build might be broken at times). This is also the main reason for the name.
  • We can use chromium-experimental to test other features as well (e.g. before using them in chromium).
  • Ozone might become the default in 2020 (which would make the attribute obsolete).

@primeos primeos self-assigned this Apr 14, 2020
@offlinehacker
Copy link
Contributor Author

Do I change this to chromium-unstable and enable ozone and hardware video decode?

@primeos
Copy link
Member

primeos commented May 13, 2020

@offlinehacker I'm not sure what you mean. I was suggesting chromium-experimental as that seems to fit best IMO while e.g. chromium-unstable sounds more like e.g. a more recent / development version (but this is up for discussion).

Regarding hardware accelerated video decode with Ozone: That seems to be tricky (and it's probably best to ignore this for now). I got past the libva initialisation errors but VA-API still wasn't selected for decoding (I didn't have a closer look, but there seem to be code paths for this). My latest attempt is here: https://github.com/primeos/nixpkgs/commits/chromium-experimental

And lastly some core members should probably decide if it's ok to build a second Chromium derivation on Hydra.

@offlinehacker
Copy link
Contributor Author

I see, so I will close this pull request for now. chromium-experimental built by hydra would be really useful.

@primeos primeos mentioned this pull request Jun 6, 2020
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @primeos