New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana: 6.7.3 -> 7.0.0 #88242
grafana: 6.7.3 -> 7.0.0 #88242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on NixOS 20.03:
[matt@servnerr-3:~/src/nixpkgs]$ nix-build -A grafana
these derivations will be built:
/nix/store/3w099kjh1m33zxfxmsxg8kn8mcry2px6-remove-references-to.drv
/nix/store/jd0qyr47s5c0p1mzz2m08rphyskz7013-source.drv
/nix/store/gf1ck2a6pq9pbzmj1wi1l77q5ysdy6ji-grafana-7.0.0-go-modules.drv
/nix/store/lda1cwfim1hsz0pd0wqn8c7fcig30486-grafana-7.0.0.linux-amd64.tar.gz.drv
/nix/store/4s5js9kkhcvqnlcbl4kzai9fwkqdy85l-grafana-7.0.0.drv
[...]
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0
shrinking /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin/slow_proxy_mac
shrinking /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin/slow_proxy
shrinking /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin/grafana-server
shrinking /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin/grafana-cli
shrinking /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin/alert_webhook_listener
strip is /nix/store/a57856fs4m8ir6vlv14h3gq3sv9aq2lb-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0/bin
patching script interpreter paths in /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0
checking for references to /build/ in /nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0...
/nix/store/53a65a2gapdyagc5vpp6k6kh99saqqy5-grafana-7.0.0
[matt@servnerr-3:~/src/nixpkgs]$ ./result/bin/grafana-server -v
Version 7.0.0 (commit: NA, branch: master)
@GrahamcOfBorg test grafana |
Before merging this, I'd like to wait for a review of @WilliButz. We should discuss if we actually want to use |
Although I am not the maintainer of this particular package, I am experienced with Go and would support moving to buildGoModule. The Grafana repository uses Go modules (note |
@JJJollyjim first of all, thanks for taking care of the update :) My opinion on Because the recent update to On the major version update: |
b85f710
to
04274b1
Compare
Release notes added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixosTests.grafana
passed and binaries seems to be working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again, but left a release notes nit.
This version removes PhantomJS support. Upstream also stopped vendoring dependencies, so I switched to buildGoModule.
Merge conflict resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade of my existing installation went smoothly, will merge after borg finished 👍
@GrahamcOfBorg test grafana |
This version removes PhantomJS support.
Upstream also stopped vendoring dependencies, so I switched to buildGoModule. I do not have the go packaging experience to fully understand the implications of this -- would appreciate review from someone who does.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)