Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: 3.3.20 -> 3.3.21, etcd_3_4: init at 3.4.8 #88225

Merged
merged 3 commits into from May 20, 2020
Merged

etcd: 3.3.20 -> 3.3.21, etcd_3_4: init at 3.4.8 #88225

merged 3 commits into from May 20, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 20, 2020

Motivation for this change

3.3 -> 3.4 isn't an easy version bump so I'd like to add 3.4 as a first step.

https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#v340-2019-08-30

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc K8s people
@johanot @offlinehacker @saschagrunert @srhb

@ofborg ofborg bot requested review from offlinehacker and kalbasit May 20, 2020 01:19
@offlinehacker
Copy link
Contributor

offlinehacker commented May 20, 2020 •
edited

Why do we need two versions is 3.3 incompatible with 3.4?

@zowoq
Copy link
Contributor Author

zowoq commented May 20, 2020

Why do we need two versions is 3.3 incompatible with 3.4?

For 3.4 the API defaults to v3 and has changes to how it handles crypto.

The modules and tests would seem to need (non-trivial?) changes to support 3.4.

I'd like to make 3.4 available for other platforms (and NixOS) for now until we can migrate from 3.3 to 3.4.

offlinehacker
offlinehacker reviewed May 20, 2020
View reviewed changes
pkgs/servers/etcd/3.4.nix Outdated
description = "Distributed reliable key-value store for the most critical data of a distributed system";
license = licenses.asl20;
homepage = "https://etcd.io/";
maintainers = with maintainers; [ offline ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add yourself as maintainer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added myself to both.

@ofborg ofborg bot requested a review from offlinehacker May 20, 2020 03:37
@offlinehacker offlinehacker merged commit c342710 into NixOS:master May 20, 2020
@zowoq zowoq deleted the etcd branch May 20, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @offlinehacker