Fix broken coloring of wielditems (#9969)

FunkyDck · web-flow · commit fe3e69eb4029 · 2020-06-09T21:38:09.000+02:00
Fixes a regression that appeared in 5.3.0-dev.
diff --git a/client/shaders/object_shader/opengl_fragment.glsl b/client/shaders/object_shader/opengl_fragment.glsl
@@ -145,8 +145,10 @@ void main(void)
 
 	vec4 col = vec4(color.rgb, base.a);
 
+	col.rgb *= gl_Color.rgb;
+
 	col.rgb *= emissiveColor.rgb * vIDiff;
-		
+
 #ifdef ENABLE_TONE_MAPPING
 	col = applyToneMapping(col);
 #endif
diff --git a/client/shaders/object_shader/opengl_vertex.glsl b/client/shaders/object_shader/opengl_vertex.glsl
@@ -38,7 +38,12 @@ void main(void)
 
 	lightVec = sunPosition - worldPosition;
 	eyeVec = -(gl_ModelViewMatrix * gl_Vertex).xyz;
-	vIDiff = directional_ambient(normalize(gl_Normal));
+
+	// This is intentional comparison with zero without any margin.
+	// If normal is not equal to zero exactly, then we assume it's a valid, just not normalized vector
+	vIDiff = length(gl_Normal) == 0.0
+		? 1.0
+		: directional_ambient(normalize(gl_Normal));
 
 	gl_FrontColor = gl_BackColor = gl_Color;
 }
diff --git a/src/client/wieldmesh.cpp b/src/client/wieldmesh.cpp
@@ -467,7 +467,11 @@ void WieldMeshSceneNode::setColor(video::SColor c)
 			bc.getGreen() * green / 255,
 			bc.getBlue() * blue / 255);
 		scene::IMeshBuffer *buf = mesh->getMeshBuffer(j);
-		colorizeMeshBuffer(buf, &buffercolor);
+
+		if (m_enable_shaders)
+			setMeshBufferColor(buf, buffercolor);
+		else
+			colorizeMeshBuffer(buf, &buffercolor);
 	}
 }
 
@@ -481,9 +485,9 @@ void WieldMeshSceneNode::setNodeLightColor(video::SColor color)
 			video::SMaterial &material = m_meshnode->getMaterial(i);
 			material.EmissiveColor = color;
 		}
-	} else {
-		setColor(color);
 	}
+
+	setColor(color);
 }
 
 void WieldMeshSceneNode::render()

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,11 @@ void WieldMeshSceneNode::setColor(video::SColor c)`
`467`	`467`	`bc.getGreen() * green / 255,`
`468`	`468`	`bc.getBlue() * blue / 255);`
`469`	`469`	`scene::IMeshBuffer *buf = mesh->getMeshBuffer(j);`
`470`		`- colorizeMeshBuffer(buf, &buffercolor);`
	`470`	`+`
	`471`	`+ if (m_enable_shaders)`
	`472`	`+ setMeshBufferColor(buf, buffercolor);`
	`473`	`+ else`
	`474`	`+ colorizeMeshBuffer(buf, &buffercolor);`
`471`	`475`	`}`
`472`	`476`	`}`
`473`	`477`
`@@ -481,9 +485,9 @@ void WieldMeshSceneNode::setNodeLightColor(video::SColor color)`
`481`	`485`	`video::SMaterial &material = m_meshnode->getMaterial(i);`
`482`	`486`	`material.EmissiveColor = color;`
`483`	`487`	`}`
`484`		`- } else {`
`485`		`- setColor(color);`
`486`	`488`	`}`
	`489`	`+`
	`490`	`+ setColor(color);`
`487`	`491`	`}`
`488`	`492`
`489`	`493`	`void WieldMeshSceneNode::render()`