New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sopel is not starting after a timeout on python 3.7 #1888
Comments
The full log seems to show it just keeps looping around (14 times) with
until it eventually gives up. This has never happened on python 3.5 |
Same here, but on 3.5.3 running Sopel 7.0.4. I get an IRC timeout and sopel doesn't reconnect. |
I've have never seen this bug on python 3.5.3 - do you have any debug logs? The only time python 3.5.3 breaks is when I break it or the starter script is broke not sopel. |
It happens frequently to me, so yes, I can add logs. |
Please ensure logging_level is set to DEBUG |
Ok, restarted with logging_level set to DEBUG. In 1-2 days I will post the log. |
|
And that's all? Nothing else before and/or after that? That's a bit thin. :-/ |
Yes, before it I had a long list of: |
But what happen after that? What does your bot? Is there anything in the exceptions log file? |
Nothing, I have to kill it and restart.Can't see anything inside default.exceptions.log. |
Weird. Getting disconnected by timeout or whatever without setting the status flags to quit or restart should pass through this whole block, log a warning after the "Closed!" info line, and reach the Lines 117 to 124 in b575787
Thought I had a tenuous lead when I spotted |
How long did you wait before killing it? Maybe you have a thread that takes too to end, or maybe you kill it before it can goes into the reconnecting state? |
I waited 20 hours, about. |
If you want to try anything I can modify the code, in 1-2 days it will happen again. |
I can't reproduce after cleaning pyc files, reinstalling everything from pip and resetting it's cache |
Closing per @RhinosF1 (both here and on IRC). @MyWay Please try cleaning up Python's cached bytecode etc. ( |
How do you delete the cache if installing from pip? |
@MyWay you can try to uninstall Sopel with pip, than re-install it? |
I did, same happens. |
See if pip has any caches, also delete any pyc files for the system. |
I have installed it with the no cache flag, so I don't think. About system pyc files I have no idea where they could be. |
Anywhere on the filesystem so cd to / and then run "find . -name "*.pyc" -delete && find . -type d -empty -delete" which will remove any pyc files and delete empty directories. I strongly suggest backups before though and being extremely careful in what you remove. You can replace -delete with -print to dry run it. |
Changed server too, now on python 3.7.3, but still having this issue. Any hint on how to find the root cause? |
All I can say is see if this still happens on current |
I see. I'm trying to disable plugins one at time. Could it be related to the whois plugin? It seems it's not happening anymore. |
Could be. What's a |
It was shipped under sopel-extras. Don't know if you replaced programmatically whois in some way. |
From the sopel-extras repo "Broken Sopel modules you might pick up and fix if you want them. Probably faster to just rewrite, though" |
Indeed, the sopel-extras repo:
We really don't support stuff in sopel-extras, and I suggest not using those plugins, maybe except for very simple ones like 8ball. |
I see, thanks. Are you aware of any other solution to have the whois command inside sopel and get the result? |
I can't even see how to trigger a WHOIS from that That said, even if it's completely unrelated, you'd probably be better off writing a new WHOIS plugin that handles things a bit differently. For example, polling for a result using |
I see, thanks. I'll wait some days to confirm the problem is somewhere there and then proceed like you said. |
I'm happy if you poke me over at phab.bots.Miraheze.wiki to consider taking ownership under @MirahezeBots of the Whois plugin. It doesn't look like that much of maintenance burden. |
The fact is: if the That being said, I'd try the bot without any extra plugins, just to be sure, and see what happens. Good luck finding the source of your problem, and I hope the root cause will because obvious soon enough so it can be fixed - either on your side, or by Sopel itself. |
Unfortunately that wasn't the problem. I have now disabled all plugins, let's see what happens. |
Description
When #1868 occurs on 3.7 we get a lot of log spam from #1865 in between
and
but the connection never recovers
Reproduction steps
Expected behavior
The two linked issues to not occur but if they do, it should recover automatically
Logs
see https://phabricator.wikimedia.org/T254348#6204886 and https://phabricator.wikimedia.org/T254348#6204907
Environment
.version
: 7.0.4/version
: ircd-seven-1.1.9(20191023-4b033a7b9221,charybdis-3.4-dev). wolfe.freenode.net eHIKMpSZ6 TS6ow 32NNotes
As far as I can see, find_lines shouldn't be being touched at that point as the connection never fully starts so of course it will be empty
The text was updated successfully, but these errors were encountered: