fetchurl: allow empty hash #89885
Merged
fetchurl: allow empty hash #89885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meant as a companion to NixOS/nix#3674 This just resets outputHash if nothing is passed in.
matthewbauer
force-pushed
the
fetchurl-no-hash
branch
from
c9d073a
to
a528cc1
Compare
We can use cacert to validate that the data passes SSL certificates. Normally, this doesn’t happen because we already have the hash, but in the hash = "" case we don’t.
|
With these PRs, we can amend our tutorials to tell people to always comment out the hash when changing the URL to avoid MITM attacks. |
Ericson2314
approved these changes
Jun 10, 2020
|
*This should probably only be merged after a Nix release contains NixOS/nix@762273f. |
|
@matthewbauer I think I'm hitting an error on this: Output (expand for `--show-trace` output):
I'm running nix-2.3.7 (which I believe to be up to date) and I think no releases of nix currently includes NixOS/nix#3674 |
|
nevermind, I can actually use a nix unstable release: |
|
Yeah - no release contains this, but it's okay since you can get the error directly from Nix instead of Nix. I think you could be hitting a bug though - fetchpypi will probably fail like this with fetchurl/boot.nix. It's been like that since 8074133 though. |
|
@baloo note there is also I wish Nixpkgs would evaluate cleanly. |
|
@FRidh good catch! |
ghost
mentioned this pull request
13 tasks
fricklerhandwerk
added a commit
that referenced
this pull request
Oct 12, 2022
#89885 ensures that fetches are done securely (i.e. without `--insecure`) when the `hash` parameter is one of the four special "fake" hashes. However the manual was not updated in that PR. This commit updates the manual to account for the already-merged changes from that PR. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant as a companion to NixOS/nix#3674
This just resets outputHash if nothing is passed in.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)