Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/make-iso9660-image: add zstd argument #89883

Closed
wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jun 9, 2020

Motivation for this change

Fixes issue introduced by #85947 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@zowoq zowoq mentioned this pull request Jun 9, 2020
10 tasks
@Kloenk
Copy link
Member

Kloenk commented Jun 9, 2020

I did not see this PR as I made my pr (#89903). But I think putting the zstd input next to the option compressImage helps to see where this is needed.

@prusnak
Copy link
Member Author

prusnak commented Jun 9, 2020

Closed in favor of #89903

@prusnak prusnak closed this Jun 9, 2020
@prusnak prusnak deleted the make-iso9660-image-zstd branch June 9, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants