Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.nixpart0: fix build #89948

Merged
merged 6 commits into from Jun 10, 2020
Merged

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Jun 9, 2020

Motivation for this change

While AFAICT not used directly in nixpkgs the package is used for provisioning new servers in nixops' Hetzner module.

This PR contains a collection of fixes for the package's dependencies to unblock its build. Closes #86403.

This branch contains the same commits as in #86403 (comment) just rebased onto more recent master.

If accepted I will make a backport PR to 20.03 as well as per the discussion on the linked issue.

/cc @nh2
/cc @kolloch @mkg20001 who might still be interested as well

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member Author

pbogdan commented Jun 9, 2020

@GrahamcOfBorg build python2Packages.nixpart0

Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request:

Please put a comment on each patch / fetchpatch that says why we need it (ideally also linking to the issue where we found the bug).

Beyond that, I have already tested this on 20.03.

@pbogdan
Copy link
Member Author

pbogdan commented Jun 10, 2020

Thanks! I added a brief note to each patch (mirroring the commit message) with a link to the issue as well. Let me know if that looks good or if there's anything else you would like me to amend.

@aszlig
Copy link
Member

aszlig commented Jun 10, 2020

@pbogdan: Thanks a lot, building and merging in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python2Packages.nixpart0 doesn't build
3 participants