Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytalk: init at 3.3.0 #89857

Merged
merged 1 commit into from Aug 24, 2020
Merged

ytalk: init at 3.3.0 #89857

merged 1 commit into from Aug 24, 2020

Conversation

Radvendii
Copy link
Contributor

Motivation for this change

I wanted to be able to use ytalk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [N/A] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :) I found a few things that needs to be fixed:

@Radvendii
Copy link
Contributor Author

Thanks for the corrections. Yeah, taeer is me. I just forgot that I put my actual name as maintainer tag.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one thing, please use pname instead of name

@Radvendii
Copy link
Contributor Author

Gotcha. Is that a new thing?

@stigtsp
Copy link
Member

stigtsp commented Jun 13, 2020

Can you also make sure the PR is only one commit containing your changes?

@stigtsp
Copy link
Member

stigtsp commented Jun 13, 2020

Gotcha. Is that a new thing?

There is some discussion on the subject here NixOS/rfcs#35, not a standard it seems.

@Radvendii
Copy link
Contributor Author

Done!

@Radvendii
Copy link
Contributor Author

Oh shoot. I thought I was squashing but actually I was deleting the new commits. I'll fix that

@Radvendii
Copy link
Contributor Author

Okay, should be good now. Double check to make sure I actually included all of your fixes, since I had to re-do them.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Result of nixpkgs-review pr 89857 1

1 package built:
- ytalk

@Lassulus
Copy link
Member

uhm, can you remove the merge commit? rebasing the changes should be preferred.

@Radvendii
Copy link
Contributor Author

Oh, I thought this was already merged into nixpkgs.

I'm not actually sure how to do what you're asking. I tried running git rebase -i <ytalk commit> and the list included neither the merge commit nor my ytalk commit.

@Radvendii
Copy link
Contributor Author

Okay, I did something that I think worked? Not sure what I did exactly, but let me know if it worked or not.

@Lassulus Lassulus merged commit 27ff76d into NixOS:master Aug 24, 2020
@stigtsp
Copy link
Member

stigtsp commented Aug 24, 2020

@Radvendii thx for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants