-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Migrate CI to GitHub Actions? #618
Comments
FTR, GitHub Actions artifacts (as I know) could not be downloaded by not logged users (e.g. there are no anonymous downloading for GitHub Actions artifacts). I may be wrong. |
You are correct (I think they do it to avoid excessive bandwidth costs). This isn't a huge problem though since we can publish a rolling "nightly" pre-release, like wasmtime does. So the artifacts would be published as assets like here. |
There's an upstream action for snapcraft: https://github.com/snapcore/action-build and it seems like arm64 and amd64 are both supported. So this seems like a good idea, snap-wise. |
@whitequark you had mentioned that the current build are debug anyway, so not suitable for general use. Would this change include producing release builds? Either way, if it makes life easier I say do it. |
We could far more easily set it up so that e.g. after debug builds succeed and go through testing, there is another round of release builds that are uploaded for general use. You can kind of do this with Travis/Appveyor but it's a huge pain with those. |
I must correct my statement regarding arm64 support: the only way to build on arm64 seems to self-hosted runners. Github-hosted runners are only amd64 as far as I can see (https://github.community/t/does-github-actions-support-multiple-os-architectures/16526). |
Closing because it looks like we're going with Travis for now. |
We can come back to this if necessary. Travis has its own problems, but it's a) there and b) has brittle arm64 support as a USP. |
I've set up GitHub Actions for a different project and was pleasantly surprised by how well they work. This has some significant potential benefits for us, including:
Any opinions or objections?
The main direct benefit is having artifact uploads, which Travis just doesn't provide at all. A potential alternative would be to use AppVeyor for everything, but I found GitHub Actions a lot less frustrating to work with than AppVeyor overall.
cc @ppd since this will impact Snap builds
The text was updated successfully, but these errors were encountered: