Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/make-iso9660: fix zstd input #89903

Merged
merged 1 commit into from Jun 10, 2020
Merged

nixos/make-iso9660: fix zstd input #89903

merged 1 commit into from Jun 10, 2020

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jun 9, 2020

Motivation for this change

hydra fails on nixos iso

Things done

fix nixos iso

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Jun 9, 2020

Looks like this is the same as #89883?

@Kloenk
Copy link
Member Author

Kloenk commented Jun 9, 2020

Looks like this is the same as #89883?

Oh, yes. But I think putting it next to the option compressImage helps to see for what it is

@Kloenk Kloenk mentioned this pull request Jun 9, 2020
Closed
10 tasks
@prusnak
Copy link
Member

prusnak commented Jun 9, 2020

Closed my PR #89883 in favor of this one

@andersk andersk requested a review from dasJ June 10, 2020 06:06
@andersk andersk added the 1.severity: channel blocker Blocks a channel label Jun 10, 2020
@andersk andersk requested a review from mmahut June 10, 2020 06:10
vcunat
vcunat approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes iso_minimal evaluation and build.

I hope there will be no other problems due to that change. I haven't tested the ISO in any way.

@vcunat vcunat merged commit bc69d29 into NixOS:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@dasJ dasJ Awaiting requested review from dasJ

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kloenk @zowoq @prusnak @vcunat @andersk