gjs: 1.64.2 -> 1.64.3 #89955
gjs: 1.64.2 -> 1.64.3 #89955
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 11-100
labels
|
Yeah, unfortunately the installedTests have been broken for a while: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.installed-tests.gjs.x86_64-linux IIRC the environment require something extra for the Gio override test. Think we looked at it when doing 3.36 without finding a solution? |
|
I only recall looking into the package tests, not installed tests. Maybe I forgot about them. Looking at the source code, I would guess this is the offending line (why no stack trace 🙀):
And Maybe something like the following would work: --- a/pkgs/development/libraries/gjs/default.nix
+++ b/pkgs/development/libraries/gjs/default.nix
@@ -96,6 +96,7 @@ in stdenv.mkDerivation rec {
postInstall = ''
wrapProgram "$installedTests/libexec/gjs/installed-tests/minijasmine" \
+ --prefix XDG_DATA_DIRS : "${glib.getSchemaPath gtk3.out}/../.." \
--prefix GI_TYPELIB_PATH : "${stdenv.lib.makeSearchPath "lib/girepository-1.0" testDeps}"
'';
|
Installed tests require GSettings schemas. And the build-time tests are now passing.
|
It seems like meson tests now succeed. I also see the following warning, which warrant investigation since we have The patch fixes installed tests too. |
The build was complaining: meson.build:660: WARNING: Your libc does not have the C.UTF-8 locale and no other suitable UTF-8 fallback locale could be found. You can still build GJS, but some tests will fail. The tests do not actually seem to be affected but still.
|
This was still awaiting review. |
|
There was an accidental mass closing of bot prs sorry. |
|
@GrahamcOfBorg build gjs |
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gjs/versions.
meta.description for gjs is: "JavaScript bindings for GNOME"
meta.homepage for gjs is: "https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Home.md"
meta.changelog for gjs is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review14 packages marked as broken and skipped:
- gnomeExtensions.icon-hider
- gnomeExtensions.system-monitor
- osxfuse
- osxsnarf
2 packages failed to build:
- pantheon.appcenter
- rpm-ostree
34 packages built:
- adapta-gtk-theme
- chrome-gnome-shell
- discover
- flatpak
- flatpak-builder
- gjs
- gnome-builder
- gnome3.anjuta
- gnome3.gnome-books
- gnome3.gnome-characters
- gnome3.gnome-control-center
- gnome3.gnome-documents
- gnome3.gnome-maps
- gnome3.gnome-session
- gnome3.gnome-shell
- gnome3.gnome-software
- gnome3.gnome-sound-recorder
- gnome3.gnome-terminal
- gnome3.gnome-tweak-tool
- gnome3.gnome-weather
- gnome3.gpaste
- gnome3.polari
- gnome3.pomodoro
- gnome3.sushi
- gnomeExtensions.drop-down-terminal
- gnomeExtensions.gsconnect
- gtkpod
- malcontent-ui
- minishift
- ostree
- pantheon.elementary-session-settings
- pantheon.sideload
- xdg-desktop-portal
- xdg-desktop-portal-gtk
Maintainer pings
cc @hedning @jtojnar @worldofpeace for testing.