Cleanup: More documentation fixes #8208
Conversation
src/window.cpp
Outdated
| @@ -3478,6 +3478,8 @@ void ReInitAllWindows() | |||
| * @param clss The class of the window to position. | |||
| * @param setting The actual setting used for the window's position. | |||
| * @return X coordinate of left edge of the repositioned window. | |||
| * | |||
| * @todo Replace \c setting magic numbers with an enumeration? | |||
There was a problem hiding this comment.
I don't like todo's like this. I agree that the function would be cleaner without the magic numbers, but it's relatively easy to make lots of todo's like this that don't add any value but distract from the actual code. For small cleanups like this I'd rather leave out the todo than add it.
There was a problem hiding this comment.
Point taken. The code is probably already littered with too many "TODO" and "XXX" comments, so I'll try to keep them to myself in future. At the very least, we can take solace in the fact that one of the previously documented todos has actually been done :)
You're more than welcome, master. |
|
You should stop with the "master" stuff. It's weird... |
Sorry, I thought that's how we did things around here. On my first pull request, someone implied I should thank the person who merged it in. |
|
"master" is the name of the branch it's being merged into, not the name of the person who did it... |
I thought it could also be a noun by proxy for the person who is merging to master. Regardless, I'll stop with the "weirdness". 😉 |
|
Ha ha, that 'say thanks master' was in some very random looking comments from kawayanslayer. No idea who / what kawayanslayer is, looked like someone testing an email bot to me, or it was just spam. 😄 Anyway, you can ignore that 😉 |
|
Thanks, master. Okay, I'll stop now 😎. |
|
It also seems rather coincidental that @kawayanslayer joined GitHub on that very same day and posted an initial one-line commit to a repository they created 🤔. |
This is in preparation for some major refactoring of the dirty block system (not to be confused with the dirty rectangle system) that is used by
gfx.cppto track portions of the screen that have been invalidated but not yet redrawn (at least, that is how I think it works; still investigating this).That, in itself, is in preparation for moving the responsibility of drawing the mouse pointer (and, probably, the "network chat message"; whatever that is) into the video driver, so it can be updated independently of the rest of the screen (moving toward fixing #7006).