New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/users-groups: Use user name not attribute name for /etc/profiles/… #89951
Conversation
I don't have a strong opinion on this, but have the question: is the canonical-according-to-Nix name the attribute name, or is it the string in the option? I would say attribute name, which makes the current behavior correct. |
Perhaps attr-name or just _ would be better, not sure. |
I believe it's the string name, which by default is the same as the attribute name [1] so it doesn't matter in most circumstances, except I have a weird setup where on my work machine my username has a different name to my home setup, so here the attribute name is [1] nixpkgs/nixos/modules/config/users-groups.nix Line 263 in 4f67c0c
|
5da8e45
to
c0ae824
Compare
I marked this as draft because I noticed
in my PC's update, which is on 0f5ce2f, I'll see if updating it changes anything. |
Hmm, fixed that problem, turns out it was my
that is, a lot of null characters, followed by an empty entry. Must have been some corruption at some point, that I caused, which would explain why I didn't see it on any other machine. |
c0ae824
to
c0fed20
Compare
c0fed20
to
0eac741
Compare
…s/... This cropped up, because I have a set-up where my work username is different to my home desktop username, and I am using a parameterized config for both, so I have something akin to config.users.users.default-user = ...; and using config.users.users.default-user.{name, home} in certain places to cope with this. Noticed my home-manager bought in packages (which use the users.users.<name>.packages hence NixOS issue not home-manager) weren't present.
0eac741
to
af4adb1
Compare
This cropped up, because I have a set-up where my work username is
different to my home desktop username, and I am using a parameterized
config for both, so I have something akin to
and using
in certain places to cope with this. Noticed my home-manager bought in
packages (which use the users.users..packages hence NixOS issue
not home-manager) weren't present.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)