resources: distinguish "dte"/"dce" roles of UARTResource #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the existing behavior, where pin directions default to DTE. Most boards will have to override the role to be DCE, though, for correct operation.
|
Seeing that all existing boards use role="dce", and #65 introduces breaking changes anyway, perhaps it makes more sense to change default role to "dce"... |
|
Should we even have a default role? I think FPGAs are equally often encountered as DCE and DTE depending on the board and what's connected to that UART. |
|
I think I was looking at SPIResource, which has default role="host". I think SPI device role is also quite common, so by that logic SPIResource also shouldn't have a default role. I can see the benefit of not having the default role, as it forces the user to think about the signal directions and the desired behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the existing behavior, where pin directions default to DTE.
Most boards will have to override the role to be DCE, though, for correct operation.
Part of the fix for #63.